Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeat "hdiutil create" commands to avoid failures #1768

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

psavery
Copy link
Collaborator

@psavery psavery commented Dec 17, 2024

Race conditions with XProtect on macos-13 can cause spurious failures
for hdiutil create commands.

As a work-around, try the hdiutil create command several times (up
to 10), and only fail if the command fails each time.

@psavery psavery force-pushed the fix-hdiutil-spurious-failures branch from 0a072b1 to 2b079f3 Compare December 17, 2024 17:51
Race conditions with XProtect on macos-13 can cause spurious failures
for `hdiutil create` commands.

As a work-around, try the `hdiutil create` command several times (up
to 10), and only fail if the command fails each time.

Signed-off-by: Patrick Avery <[email protected]>
@psavery psavery force-pushed the fix-hdiutil-spurious-failures branch from 2b079f3 to 0d9baee Compare December 17, 2024 19:17
@psavery psavery marked this pull request as ready for review December 17, 2024 23:22
@psavery psavery requested a review from bnmajor December 17, 2024 23:22
Copy link
Collaborator

@bnmajor bnmajor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@psavery psavery merged commit 164b618 into master Dec 18, 2024
9 checks passed
@psavery psavery deleted the fix-hdiutil-spurious-failures branch December 18, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants