Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update frontend Dockerfile to use production mode for build #3520

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fpigeonjr
Copy link
Contributor

What changed

fix: update frontend Dockerfile to use production mode for build
needs testing in staging

How to test

Don't see this in dev/staging

image

Definition of Done Checklist

  • [-] OESA: Code refactored for clarity
  • [-] OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • [-] 90%+ Code coverage achieved
  • [-] Form validations updated

Links

https://vite.dev/guide/cli.html#vite-build

@jonnalley
Copy link
Contributor

🤔

Copy link
Contributor

@johndeange johndeange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we want to do this - it will remove our ability to have environment specific UI builds.

@fpigeonjr
Copy link
Contributor Author

@johndeange @jonnalley do you see the react warning about development builds in production?

Wonder if it makes sense to ever have a react development build in any deployed environment?
Thinking it only makes sense in local development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants