Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: fixed can id filtering #3544

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Hotfix: fixed can id filtering #3544

wants to merge 1 commit into from

Conversation

weimiao67
Copy link
Collaborator

What changed

Filtering portfolio funding can by budget year instead of can fiscal year.

Issue

#3274

How to test

  1. e2e test pass or test manually
  2. goto portfolio 1, portfolio funding tab.
  3. select fiscal year 2023
  4. should show 2 can cards
  5. switch to fiscal year 2021
  6. should show 2 can cards

Definition of Done Checklist

  • OESA: Code refactored for clarity
  • OESA: Dependency rules followed
  • Automated unit tests updated and passed
  • Automated integration tests updated and passed
  • Automated quality tests updated and passed
  • Automated load tests updated and passed
  • Automated a11y tests updated and passed
  • Automated security tests updated and passed
  • 90%+ Code coverage achieved
  • Form validations updated

@weimiao67 weimiao67 added the bug Something isn't working label Feb 27, 2025
@weimiao67 weimiao67 self-assigned this Feb 27, 2025
fpigeonjr
fpigeonjr approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@fpigeonjr fpigeonjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆 W

@jonnalley
Copy link
Contributor

Reminds me of #3506

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndeange johndeange johndeange approved these changes

@fpigeonjr fpigeonjr fpigeonjr approved these changes

@jonnalley jonnalley Awaiting requested review from jonnalley

@rajohnson90 rajohnson90 Awaiting requested review from rajohnson90

@maiyerlee maiyerlee Awaiting requested review from maiyerlee

@Santi-3rd Santi-3rd Awaiting requested review from Santi-3rd

At least 3 approving reviews are required to merge this pull request.

Assignees

@weimiao67 weimiao67

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@weimiao67 @jonnalley @johndeange @fpigeonjr