-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue #2696] add New Relic to Next app #2922
Conversation
2797d84
to
fd006d6
Compare
3a9b6c5
to
666938b
Compare
666938b
to
0998a9c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obvs only reviewing "my" half of the PR, but I have optional feedback
0a8bf7a
to
77de743
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐑 it
77de743
to
c7a40ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏿
Summary
Fixes #2696
Time to review: 15 mins
Changes proposed
The goal is to begin sending data to New Relic from the frontend Next application. Things that have been done:
Context for reviewers
Test steps
NEW_RELIC_APP_NAME="<see 1pass>" NEW_RELIC_LICENSE_KEY="<see 1pass>" npm run dev:nr
Additional information
Screenshots after deploying to DEV
Next Steps