Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #2696] add New Relic to Next app #2922

Merged
merged 6 commits into from
Nov 26, 2024

Conversation

doug-s-nava
Copy link
Collaborator

@doug-s-nava doug-s-nava commented Nov 19, 2024

Summary

Fixes #2696

Time to review: 15 mins

Changes proposed

The goal is to begin sending data to New Relic from the frontend Next application. Things that have been done:

Context for reviewers

Test steps

  1. start next on this branch with NEW_RELIC_APP_NAME="<see 1pass>" NEW_RELIC_LICENSE_KEY="<see 1pass>" npm run dev:nr
  2. visit some pages and perform searches
  3. VERIFY: data comes through into New Relic, in both APM and browser dashboards

Additional information

Screenshots after deploying to DEV

Screenshot 2024-11-22 at 10 04 24 AM
Screenshot 2024-11-22 at 10 03 50 AM

Next Steps

  • open an issue and possibly a PR with DefinitelyTyped to fix typing issues https://github.com/DefinitelyTyped/DefinitelyTyped
  • deploy to DEV to confirm functionality in deployed environment
  • confirm expected behavior in PROD (data comes in) and Staging (data does not come in) after deployment
  • documentation

@doug-s-nava doug-s-nava force-pushed the dschrashun/2696-new-relic-setup branch from 2797d84 to fd006d6 Compare November 19, 2024 15:59
@doug-s-nava doug-s-nava force-pushed the dschrashun/2696-new-relic-setup branch 2 times, most recently from 3a9b6c5 to 666938b Compare November 21, 2024 19:35
@doug-s-nava doug-s-nava marked this pull request as ready for review November 21, 2024 19:50
@doug-s-nava doug-s-nava force-pushed the dschrashun/2696-new-relic-setup branch from 666938b to 0998a9c Compare November 21, 2024 19:53
coilysiren
coilysiren previously approved these changes Nov 21, 2024
Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obvs only reviewing "my" half of the PR, but I have optional feedback

infra/frontend/app-config/dev.tf Outdated Show resolved Hide resolved
infra/frontend/app-config/prod.tf Outdated Show resolved Hide resolved
@doug-s-nava doug-s-nava force-pushed the dschrashun/2696-new-relic-setup branch from 0a8bf7a to 77de743 Compare November 22, 2024 15:09
coilysiren
coilysiren previously approved these changes Nov 22, 2024
Copy link
Collaborator

@coilysiren coilysiren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐑 it

Copy link
Collaborator

@mdragon mdragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Collaborator

@acouch acouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏿

@doug-s-nava doug-s-nava merged commit f51f5db into main Nov 26, 2024
19 checks passed
@doug-s-nava doug-s-nava deleted the dschrashun/2696-new-relic-setup branch November 26, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate NewRelic beacons from the frontend
4 participants