[Issue #2793] Create Extract Metadata API #2963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ps://github.com/HHS/simpler-grants-gov into mikehgrantsgov/2793-create-extract-metadata-api
chouinar
reviewed
Nov 21, 2024
chouinar
reviewed
Nov 21, 2024
Comment on lines
18
to
25
| def test_extract_metadata_get_default_dates( | ||
| client, api_auth_token, enable_factory_create, db_session | ||
| ): | ||
| """Test that default date range (last 7 days) is applied when no dates provided""" | ||
| ExtractMetadataFactory.create_batch( | ||
| 2, | ||
| extract_type=ExtractType.OPPORTUNITIES_JSON, | ||
| ) |
There was a problem hiding this comment.
Could you add a record that is older/newer than the last 7 days?
There was a problem hiding this comment.
Could you add at least one test that verifies the file can be downloaded / the pre-signing works.
Can probably just steal some of what https://github.com/HHS/simpler-grants-gov/blob/main/api/tests/src/api/opportunities_v1/test_opportunity_route_get.py#L111 does which is testing the presigned logic for GET opportunities.
There was a problem hiding this comment.
Sure, I just added this. Used some adaptation from that example you sent, thanks.
Co-authored-by: Michael Chouinard <[email protected]>
Co-authored-by: Michael Chouinard <[email protected]>
Co-authored-by: Michael Chouinard <[email protected]>
mikehgrantsgov
deleted the
mikehgrantsgov/2793-create-extract-metadata-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2793
Time to review: 30 mins
Changes proposed
Add a new Blueprint / API for the extract metadata API.
Add tests for all business rules and data retrieval
Context for reviewers
Population of the table will be addressed in a follow-on ticket.
Additional information
Open questions:
Should this be called V1 to follow the opportunity API convention?
extract_typeis a filter in the POST param vs an explicit path param in the URL. Is that OK?See unit tests for additional context.