[Issue #2976] Run analytics migrations like the API does them #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coilysiren
requested review from
acouch,
mdragon and
widal001
as code owners
DavidDudas-Intuitial
requested changes
Nov 21, 2024
| @@ -18,7 +18,7 @@ | |||
| VERBOSE = False | |||
|
|
|||
|
|
|||
| def initialize_database() -> None: | |||
| def db_migrate() -> None: | |||
There was a problem hiding this comment.
nit: please change this to migrate_database
analytics/src/analytics/cli.py
Outdated
| def initialize_database() -> None: | ||
| @etl_app.command(name="db_migrate") | ||
| @ecs_background_task("db_migrate") | ||
| def db_migrate() -> None: |
There was a problem hiding this comment.
nit: please change this to migrate_database
DavidDudas-Intuitial
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2976
Time to review: 5 mins
Changes proposed
init-etldbcronjob since we are now running that same logic on mergeinfra/analytics/app-config/outputs.tfactivates this)Testing
https://github.com/HHS/simpler-grants-gov/actions/runs/11960219381/job/33346703132#step:5:256