clean up messy GA env var situation #3025
Open
+29
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-s-nava
requested review from
coilysiren,
acouch,
mdragon,
andycochran and
widal001
as code owners
coilysiren
reviewed
Nov 26, 2024
|
|
||
| ## Deployment | ||
|
|
||
| [Check out this diagram](https://lucid.app/lucidchart/107dcf47-46e7-4088-a90a-1ef3b0ca3744/edit?viewport_loc=42%2C439%2C2295%2C1182%2C0_0&invitationId=inv_3559eb81-f735-4b22-9365-49920268e061). This should explain most of what the next section explains, and more but in visual form. |
There was a problem hiding this comment.
This isn't a public URL - can you embed a screenshot?
There was a problem hiding this comment.
Yeah, that was my first thought, but wasn't sure where to host it. Any ideas?
acouch
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3033
Time to review: 10 mins
Changes proposed
Cleans up after bug introduced in https://github.com/HHS/simpler-grants-gov/pull/3001/files and fixed in #3013
Adds some more detail to the documentation and adds a diagram as well.
Context for reviewers
Test steps
This should also be verified in DEV after merge
** PLEASE REVIEW THE DIAGRAM AS WELL **
Additional information