Email Signup Submission Fixed #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @Kajol-Kumari Please review it and merge it |
Kajol-Kumari
reviewed
Aug 7, 2024
| e.preventDefault(); | ||
| //if isValid = true, form submission trigger | ||
| const isValid = validation(); | ||
| if (isValid) { | ||
| setSubmited(true); |
There was a problem hiding this comment.
For every new user, there should be a welcome email sent to the subscribers
There was a problem hiding this comment.
It's a frontend part... the email sent part should be done in backend.
Merge the request and i will add the email functionality in new issue.
Yeah It not stored if email already exists. |
|
Close the current request I will add email functionality on issue #1120 Assign me that issue |
Kajol-Kumari
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Closes: #878
Proposed changes
Integrated into backend and toast message added.
Types of changes
Put an
xin the boxes that applyScreenshots