Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerized the whole application #652

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Dockerized the whole application #652

wants to merge 4 commits into from

Conversation

Jassi10000-zz
Copy link

Issue that this pull request solves

Closes: # (issue number)
#543

Proposed changes

Brief description of what is fixed or changed

I made the respective changes to the project to provide a dockerized solution of the application

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@auto-assign auto-assign bot requested a review from Abhishek971999 May 18, 2021 21:15
@Kajol-Kumari Kajol-Kumari requested review from jackfrost13 and removed request for Abhishek971999 May 19, 2021 15:40
@@ -1,11 +1,17 @@
import React, { useState } from "react";
import Joi from "joi-browser";
<<<<<<< HEAD
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you haven't resolved the merge conflicts
resolve those and request for review

Copy link
Author

@Jassi10000-zz Jassi10000-zz May 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to do that but Idk why they aren't being reflected
@Kajol-Kumari Can you pls help me in this , the way I did I think it got more messed up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants