Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backend] Add Delete API for Questions and Answers Fixed #920

Merged
merged 1 commit into from
May 18, 2024
Merged

[Backend] Add Delete API for Questions and Answers Fixed #920

merged 1 commit into from
May 18, 2024

Conversation

Hemu21
Copy link
Contributor

@Hemu21 Hemu21 commented May 18, 2024

Issue that this pull request solves

Issue Link resolve #889
Closes: #889

Brief description of what is fixed or changed

I had added backend functionality and endpoint to delete question and answer.
 

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots or Video

kajolcheck.mp4

github-advanced-security[bot]
github-advanced-security bot found potential problems May 18, 2024
View reviewed changes
backend/app/routes/Q&A/answers/index.js
@@ -23,4 +25,7 @@
// Update Answer Status
router.patch('/updateStatus', validation(updateAnswerStatusSchema), updateAnswerStatus);

// Delete Answer by Id
router.delete('/deleteanswer', authMiddleware, deleteAnswer);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
backend/app/routes/Q&A/answers/index.js
@@ -23,4 +25,7 @@
// Update Answer Status
router.patch('/updateStatus', validation(updateAnswerStatusSchema), updateAnswerStatus);

// Delete Answer by Id
router.delete('/deleteanswer', authMiddleware, deleteAnswer);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
backend/app/routes/Q&A/question/index.js
@@ -25,4 +27,7 @@
// route for updating the question status
router.patch('/updateStatus', validation(updateQuestionStatusSchema), updateQuestionStatus);

// route for deleting the question with answers
router.delete('/deletequestion', authMiddleware, deleteQuestion);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
authorization
Loading
, but is not rate-limited.
backend/app/routes/Q&A/question/index.js
@@ -25,4 +27,7 @@
// route for updating the question status
router.patch('/updateStatus', validation(updateQuestionStatusSchema), updateQuestionStatus);

// route for deleting the question with answers
router.delete('/deletequestion', authMiddleware, deleteQuestion);

Check failure

Code scanning / CodeQL

Missing rate limiting High

This route handler performs
a database access
Loading
, but is not rate-limited.
This route handler performs
a database access
Loading
, but is not rate-limited.
@Hemu21
Copy link
Contributor Author

Hemu21 commented May 18, 2024

@Kajol-Kumari can you please check and merge it.

Kajol-Kumari
Kajol-Kumari approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and Clean! Seems like all validations are also in place.

@Kajol-Kumari Kajol-Kumari added level3 New features, major bug fixing. gssoc GSSoC'24 Label labels May 18, 2024
@Kajol-Kumari Kajol-Kumari merged commit 8836396 into HITK-TECH-Community:main May 18, 2024
6 of 7 checks passed
@Hemu21
Copy link
Contributor Author

Hemu21 commented May 18, 2024

@Kajol-Kumari Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kajol-Kumari Kajol-Kumari Kajol-Kumari approved these changes

Assignees

@Hemu21 Hemu21

Labels
gssoc GSSoC'24 Label level3 New features, major bug fixing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Backend] Add Delete API for Questions and Answers
2 participants
@Hemu21 @Kajol-Kumari