changed "ask your question ui" #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kajol-Kumari
requested review from
Kajol-Kumari
and removed request for
jackfrost13
Kajol-Kumari
requested changes
May 18, 2024
frontend/src/app.js
Outdated
| @@ -1,6 +1,6 @@ | |||
| import { Fragment, useEffect, useState } from "react"; | |||
| import { | |||
| BrowserRouter as Router, | |||
| // BrowserRouter as Router, | |||
There was a problem hiding this comment.
can you revert this change?
| color: "#69a9dd", | ||
| fontSize: "25px", | ||
| textAlign: "center", | ||
| // paddingLeft: "1.5rem", |
There was a problem hiding this comment.
[neat] remove this if its not required
| @@ -1,5 +1,5 @@ | |||
| import React, { useState } from "react"; | |||
| import { NavLink, useHistory } from "react-router-dom"; | |||
| // import { NavLink, useHistory } from "react-router-dom"; | |||
There was a problem hiding this comment.
[ques] why did we commented it?
Kajol-Kumari
added
level1
Kajol-Kumari
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue that this pull request solves
Closes: #909
Proposed changes
Change in "Ask your question " ui
Brief description of what is fixed or changed
Changed the background color of close button and arranged the tags in grind and made it more compact
Types of changes
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that applyScreenshots
Please attach the screenshots of the changes made in case of change in user interface
Other information
Any other information that is important to this pull request