Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I need help #29

Merged
merged 5 commits into from
Jun 8, 2021
Merged

I need help #29

merged 5 commits into from
Jun 8, 2021

Conversation

markiantorno
Copy link
Collaborator

@ericprud
@grahamegrieve
@lmckenzi

I have no idea what I'm doing with this code. This code currently does not work.

All the dependencies have been updated so that they use the releases on OSS Sonatype for the weso libraries. The old bintray ones no longer work.

There are three errors left that need to be addressed:

1.

/home/mark/Documents/Projects/FHIR/kindling/src/main/java/org/hl7/fhir/rdf/ShExValidator.java:27: error: cannot find symbol
        return ShExSchema$.MODULE$.fromString(contents, "SHEXC", none).get();
                                                                      ^
  symbol:   method get()
  location: class IO<ShExSchema>

2.

/home/mark/Documents/Projects/FHIR/kindling/src/main/java/org/hl7/fhir/rdf/ShExValidator.java:32: error: constructor RDFAsJenaModel in class RDFAsJenaModel cannot be applied to given types;
        RDFReader rdf = new RDFAsJenaModel(dataModel);
                        ^
  required: Ref<IO,Model>,Option<IRI>,Option<IRI>,Map<RDFNode,Set<Location>>,Map<RDFTriple,Set<Location>>
  found: Model
  reason: actual and formal argument lists differ in length

3.

/home/mark/Documents/Projects/FHIR/kindling/src/main/java/org/hl7/fhir/rdf/ShExValidator.java:33: error: no suitable method found for validate(RDFReader,String,Option<String>,Option<String>,IO<PrefixMap>,PrefixMap)
        Result result = schema.validate(rdf, "TARGETDECLS", none, none, rdf.getPrefixMap(), schema.pm());

Can you please help in resolving them? I don't know what the code is supposed to do, so it's difficult for me to fix it. It appears to just be differences in the method signatures and method availability, from the old versions (0.0.60) to the current, updated ones.

Thanks.

@grahamegrieve
Copy link
Contributor

I thnk Jose will need to help - I think this is all code I just copied from one if his projects. I certainly don't understand what's going on with those method changes.

@ericprud
Copy link

ericprud commented Jun 7, 2021

I thnk Jose will need to help - I think this is all code I just copied from one if his projects. I certainly don't understand what's going on with those method changes.

@labra, that's your queue (though @iovka probably knows 1. better)

@labra
Copy link

labra commented Jun 7, 2021

I thnk Jose will need to help - I think this is all code I just copied from one if his projects. I certainly don't understand what's going on with those method changes.

@labra, that's your queue (though @iovka probably knows 1. better)

Yes, I am planning to update the code to adapt to the new changes in the library.

@ericprud
Copy link

ericprud commented Jun 7, 2021

@labra, that's your queue (though @iovka probably knows 1. better)

Sorry, I was thinking we were using shex-java.
BTW, @markiantorno , we have a goal to align the APIs for shex-java and shex-scala so that they'd be drop-in replacements for each other (i.e. give you the ability to swap them when you see suspicious behavior).

@labra
Copy link

labra commented Jun 7, 2021

I created a new PR because #30 because I didn't know how to update this one.

The PR is just a temporary hack so you can keep your pipeline working. In the long term, I also agree that it will be very useful to have a common API to invoke the ShEx libraries.

@ericprud
Copy link

ericprud commented Jun 8, 2021

Re common API, I created https://hackmd.io/OiNBXuPYR3mRPaQ-wk-xWw which links to issues in :

@markiantorno markiantorno merged commit 91065df into main Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants