-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for visualization and relative positioning in refactored playback server #15
base: master
Are you sure you want to change the base?
Conversation
Ported modifications to the refactored code as well but these haven't been fully tested yet
Fixes error when eef_pose = True and no zero marker provided Warns rather than crashes upon ImportErrors from configured record topics
Requires support arm_movit.py in hlpr_manipulation
Going through the code now. I can't seem to find what branch or location for the arm_moveit.py changes that are required. I can't test the rest of this until I know what changes need to be made for arm_moveit.py. EDIT: Hm nvm. Looks like the change is on the master branch and not the 7dof. I'll go ahead and merge in the changes to the 7dof arm branch. |
I think those were made in on master a little while back. Is there anything I forgot to push? |
Yup, I just checked the master and you're right it is there. I'm on the 7dof branch. Pulling in changes now. Thanks for the quick response! |
No problem! |
@petschekr Can you add some more details in the documentation? Currently, it is unclear how I'm supposed to visualized the recorded point clouds (or maybe I'm not supposed to?) Also, there are a bunch of new features you've added (object location, etc.) that haven't been documented at all in the wiki. |
Another thing :) So once the user has previewed the trajectory. We need a way to select that specific trajectory (the .pkl saved) and play that exact trajectory. I tried selecting the pkl file from the GUI and it errors out:
My guess it is because it isn't designed for it at all. Can you either add another field in the GUI or a case where if the user loads the PKL file, it will play back that exact pkl trajectory? This is higher priority than orientation currently. Without guaranteeing that the viewed trajectory is the one the robot will execute, we can't guarantee the robot won't collide with anything. If the system does it already by default, then it should be clear in some sort of status that it is playing back the previewed trajectory. |
@vchu Loading and playing back Visualizing recorded point clouds from Also, I'm working on documenting all of the new features now. |
Documentation updated at https://github.com/HLP-R/hlpr_documentation/wiki/Kinesthetic-Teaching-GUI |
holding off on this PR until some weird double playback has been resolved that might or might not be related to any of these changes. |
…pping compensation for first keyframe
Nice! Will get to testing it later today or tomorrow. |
No description provided.