Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump flask from 2.3.3 to 3.0.0 #774

Merged
merged 9 commits into from
Dec 6, 2023
Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 2, 2023

Bumps flask from 2.3.3 to 3.0.0.

Release notes

Sourced from flask's releases.

3.0.0

This is a feature release, which includes new features, removes previously deprecated code, and adds new deprecations. The 3.0.x branch is now the supported fix branch, the 2.3.x branch will become a tag marking the end of support for that branch. We encourage everyone to upgrade, and to use a tool such as pip-tools to pin all dependencies and control upgrades. Test with warnings treated as errors to be able to adapt to deprecation warnings early.

Changelog

Sourced from flask's changelog.

Version 3.0.0

Released 2023-09-30

  • Remove previously deprecated code. :pr:5223
  • Deprecate the __version__ attribute. Use feature detection, or importlib.metadata.version("flask"), instead. :issue:5230
  • Restructure the code such that the Flask (app) and Blueprint classes have Sans-IO bases. :pr:5127
  • Allow self as an argument to url_for. :pr:5264
  • Require Werkzeug >= 3.0.0.
Commits
  • 735a470 Release version 3.0.0
  • efe39ae Bump Werkzeug 3.0.0
  • 438edcd Allow self as an argument to url_for
  • b7c1290 Fix wrong spelling of JS method .innerHTML
  • 8037487 Bump pypa/gh-action-pypi-publish from 1.8.8 to 1.8.10 (#5248)
  • e8076d9 Bump slsa-framework/slsa-github-generator from 1.7.0 to 1.9.0 (#5247)
  • ecc4a38 Bump actions/checkout from 3.5.3 to 3.6.0 (#5246)
  • 24c6508 Bump pypa/gh-action-pypi-publish from 1.8.8 to 1.8.10
  • 98cef9f Bump slsa-framework/slsa-github-generator from 1.7.0 to 1.9.0
  • 0c97a41 Bump actions/checkout from 3.5.3 to 3.6.0
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Bumps [flask](https://github.com/pallets/flask) from 2.3.3 to 3.0.0.
- [Release notes](https://github.com/pallets/flask/releases)
- [Changelog](https://github.com/pallets/flask/blob/main/CHANGES.rst)
- [Commits](pallets/flask@2.3.3...3.0.0)

---
updated-dependencies:
- dependency-name: flask
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Oct 2, 2023
@tunetheweb tunetheweb requested a review from rviscomi October 19, 2023 23:18
@tunetheweb
Copy link
Member

tunetheweb commented Oct 19, 2023

@rviscomi looks like our markdown conversion tool does not work with Flask 3.0.0 as it uses deprecated calls that have since been removed. It also looks like that project has been abandoned as no updates for a few years. I tried to update it myself to open a PR and the update is simple but test cases were problematic.

Anyway so I removed to writing our own extension and that seems to work just as well. Probably best to remove the dependency anyway if not actively supported.

One small issue is you might notice some extra debug logging in the server logs but this is a known issue with the Markdown library so not much we can do about that.

@tunetheweb tunetheweb merged commit f392c4d into main Dec 6, 2023
5 checks passed
@tunetheweb tunetheweb deleted the dependabot/pip/flask-3.0.0 branch December 6, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant