Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SMILES formula to SMILES string #235

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Update SMILES formula to SMILES string #235

merged 3 commits into from
Feb 13, 2024

Conversation

edeutsch
Copy link
Contributor

@edeutsch edeutsch commented Feb 9, 2024

No description provided.

edeutsch
edeutsch commented Feb 9, 2024
View reviewed changes
Copy link
Contributor Author

@edeutsch edeutsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks! I'm not permitted to approve, but I approve.

@edeutsch
Copy link
Contributor Author

Anything need to be done before merging this? I think we agreed at the call to merge, so don't need any more approvals, I think.

@mobiusklein mobiusklein added this pull request to the merge queue Feb 13, 2024
Merged via the queue into master with commit 16631ef Feb 13, 2024
2 checks passed
@bittremieux bittremieux deleted the edeutsch-smiles branch January 17, 2025 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mobiusklein mobiusklein mobiusklein approved these changes

@jshofstahl jshofstahl Awaiting requested review from jshofstahl

@henryhlam henryhlam Awaiting requested review from henryhlam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@edeutsch @mobiusklein