Protein contaminant ratio #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Quant, which can subsume multiple MS runs per group.
bittremieux
approved these changes
Mar 19, 2024
|
IMHO ready for merge from our side :) |
edeutsch
reviewed
Apr 2, 2024
There was a problem hiding this comment.
This looks okay to me, except maybe the "intensity" in the name. The name has "intensity" but the description only talks about "abundance". These two concepts are related but not really equal. "ratio" and "fraction" are also variously used in ways that are unclear. "fraction of total protein" is clear. "ratio" only serves to confuse the issue, I think.
I'm thinking the name would be better "contaminant protein abundance fraction".
|
point well made. |
edeutsch
approved these changes
Apr 3, 2024
|
whops. Fixed the name. Thanks Eric. Ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: new version assumes that #245 is merged first.