-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accession order fixes #330
Conversation
Do we need to increase the version number? It's just a re-ordering of terms. Content is identical. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I think the GitHub actions/checking requires every change to have a bump in version number.
good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, I had not considered the CV being unsorted by accession when I wrote the niche finder.
It is highly improbable that this breaks things for people directly consuming the OBO file.
Enhances
scripts/find_next_available_number.py
to report the gap size and also now detects an unsorted CV (which would cause reporting of false positive gaps).e.g.
Ordering of accessions is restored as well in this PR (eliminating
CV is not sorted! MS:1003407 found after MS:4000181
).This might be worth adding to GH actions? i.e. fail if not sorted?