Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new spectrum origin type #337

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Add new spectrum origin type #337

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
078ea9e
Add new spectrum origin type
edeutsch Sep 27, 2024
a85ea64
Merge branch 'master' into edeutsch-new-spec-origin-type
mobiusklein Oct 11, 2024
85462eb
Update psi-ms.obo
mobiusklein Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions psi-ms.obo
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about "reduced spectrum for peptide-centric scoring" or "transition list spectrum" or "selected known product ion spectrum"?

The definition is OK, except that it looks a bit run-on. May need a connector "whose" after the first comma.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that the definition is ok, the name takes a bit more effort to parse on its own though.

Maybe instead something like "selected fragment observed intensity spectrum"? The "selected" indicates that only a limited set of peaks are included, the "fragment" implicitly indicates that it's known fragments, thus theoretical m/z, and the "observed intensity" indicates that the intensity values are determined experimentally.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for "selected fragment observed intensity spectrum". It's succinct and conveys the concept and doesn't tie it to any particular domain.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not making it a bit more self explanatory? Unless we really want a short name: "Spectrum containing selected fragment ion peaks and experimental intensity"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. "theoretical m/z observed intensity selected fragment spectrum"
  2. "selected fragment theoretical m/z observed intensity spectrum" +++

def: "Spectrum for which the peaks are limited to a subset of known product ions that are important for subsequent identification, whose m/z values are corrected to theoretical values, and intensity values are experimentally derived." [PSI:PI]

Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
format-version: 1.2
data-version: 4.1.180
date: 04:10:2024 07:15
data-version: 4.1.181
date: 11:10:2024 07:15
saved-by: Joshua Klein
auto-generated-by: OBO-Edit 2.3.1
default-namespace: MS
Expand Down Expand Up @@ -22649,6 +22649,12 @@ name: Orbitrap Exploris GC 240
def: "Orbitrap Exploris GC 240 Mass Spectrometer." [PSI:MS]
is_a: MS:1000494 ! Thermo Scientific instrument model

[Term]
id: MS:1003424
name: selected fragment theoretical m/z observed intensity spectrum
def: "Spectrum for which the peaks are limited to a subset of known product ions that are important for subsequent identification, whose m/z values are corrected to theoretical values, and intensity values are experimentally derived." [PSI:PI]
is_a: MS:1003072 ! spectrum origin type

[Term]
id: MS:4000000
name: PSI-MS CV Quality Control Vocabulary
Expand Down
Loading