Replace quartile/quarter -> quantile #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianu
approved these changes
Jan 14, 2025
mwalzer
requested changes
Jan 14, 2025
| @@ -22998,8 +22998,8 @@ relationship: has_units UO:0000010 ! second | |||
|
|
|||
| [Term] | |||
| id: MS:4000052 | |||
| name: XIC-Height quartile ratios | |||
| def: "The log ratio of successive XIC height quartiles. The metric's value triplet represents the log ratios of XIC-height-Q2 to XIC-height-Q1, XIC-height-Q3 to XIC-height-Q2, XIC-height max to XIC-height-Q3." [PSI:MS] | |||
| name: obsolete XIC-Height quartile ratios | |||
There was a problem hiding this comment.
Maybe not change the name by adding obsolete? The other obsolete term in the .obo didn't go through a name change either as far as I can find.
There was a problem hiding this comment.
Leaving the names as-is is another layer of backwards compatibility, but it's not guaranteed the way the id is guaranteed to never change.
There was a problem hiding this comment.
I got these instructions from the Protege website for obsoleting terms, but happy to modify it according to conventions adopted by the PSI-MS CV.
edeutsch
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some QC terms that were defined as "quartiles" or "quarters" have now been replaced by more general "quantile" terms.
Fixes mzQC#259.