-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description and settings for a dev setup #39
base: master
Are you sure you want to change the base?
Conversation
The rendered new README can be previewed at https://github.com/hd1ex/shiftings/tree/dev-setup. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, minor suggestions
f5e8b7b
to
174a4c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good
README.md
Outdated
|
||
#### Database setup | ||
|
||
The script [setup_db.py](setup_db.py) initializes your database with the schema matching the shiftings models (running `manage.py migrate`) and [loading the fixtures](https://docs.djangoproject.com/en/5.1/howto/initial-data/) providing example data. Execute it for having a local database: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now this is setup_db.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mich triggert es außerdem, dass da so viel Text und so viele Befehle stehen, weil mein ADHS Gehirn gerne einfach alle Commands die es sieht, einfach in ne Commandline reinhauen will, aber man eigentlich nur den untersten brauch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Das Dokument ist so aufgebaut, dass man die von Github hervorgehobenen Befehle ausführen muss, um ein sinnvolles Setup zu bekommen. Wir kennen alle Python und manchmal funktioniert etwas nicht. Insbesondere deswegen finde ich es schon wichtig für die Leute auch hinzuschreiben, was abgeht. Außerdem gehe ich mal davon aus, dass nicht jeder Programmierer ein ADHS-Gehirn hat :)
Für deinen Vorschlag kann man entweder ein TLDR oben hinzufügen, den Stil des Dokuments wie ich oben gerade kurz einführen oder noch ein Skript machen. Mir egal wie, das sollte man aber dann in einem anderen Change machen. Lass das jetzt endlich mal mergen, wenn es inhaltlich passt.
No description provided.