Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiohttp from 3.10.10 to 3.10.11 #536

Open
wants to merge 1 commit into
base: habana_main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Nov 21, 2024

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 21, 2024
@michalkuligowski
Copy link

@RonBenMosheHabana please check above, it fails on Trigger Jenkins Tests

---
updated-dependencies:
- dependency-name: aiohttp
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@RonBenMosheHabana RonBenMosheHabana force-pushed the dependabot/pip/aiohttp-3.10.11 branch from 9b2ac57 to 97c1afc Compare November 24, 2024 08:03
@RonBenMosheHabana RonBenMosheHabana self-requested a review November 24, 2024 08:05
@RonBenMosheHabana
Copy link
Collaborator

@RonBenMosheHabana please check above, it fails on Trigger Jenkins Tests

It can be merged
I rebased habana_main into this branch
it currently failing because by definition dependabot doesn't have access to GitHub secrets ( the webhook to Jenkins is configured as secret) therefore it can't actually trigger the Jenkins tests
It doesn't blocked the PR from being merged

@michalkuligowski
Copy link

@RonBenMosheHabana stock vllm has 3.10.10 version I suggest we keep that for now https://github.com/vllm-project/vllm/blob/main/requirements-test.txt#L15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants