Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bugfix] fix RuntimeError on apc #648

Merged
merged 1 commit into from
Jan 7, 2025
Merged

[bugfix] fix RuntimeError on apc #648

merged 1 commit into from
Jan 7, 2025

Conversation

kkimmk
Copy link

@kkimmk kkimmk commented Dec 19, 2024 •
edited by github-actions bot
Loading

This PR fixes a bug that results in the following RuntimeError when APC is enabled.

ERROR 12-19 02:30:05 engine.py:140]   File "/workspace/vllm/worker/hpu_model_runner.py", line 854, in _prepare_prompt
ERROR 12-19 02:30:05 engine.py:140]     if prefix_block_list_tensor:
ERROR 12-19 02:30:05 engine.py:140] RuntimeError: Boolean value of Tensor with more than one value is ambiguous

jkaniecki
jkaniecki approved these changes Jan 7, 2025
View reviewed changes
Copy link

@jkaniecki jkaniecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalkuligowski michalkuligowski merged commit 5d582b5 into HabanaAI:habana_main Jan 7, 2025
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaniecki jkaniecki jkaniecki approved these changes

@michalkuligowski michalkuligowski michalkuligowski approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@madamczykhabana madamczykhabana Awaiting requested review from madamczykhabana madamczykhabana is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz mgawarkiewicz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kkimmk @michalkuligowski @jkaniecki