Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for random sampler recompilations for incomplete batches #663

Merged
merged 14 commits into from
Jan 22, 2025
Merged

Fix for random sampler recompilations for incomplete batches #663

merged 14 commits into from
Jan 22, 2025

Conversation

mfylcek
Copy link

@mfylcek mfylcek commented Dec 30, 2024 •
edited
Loading

Changes the sampler used by dummy sequences to random if all other sequences are using it. Prevents sampler recompilations.

@mfylcek mfylcek changed the title Sampler-aware batch_size padding Fix for sampler recompilations when using random sampler with batch_size padding Dec 30, 2024
@mfylcek mfylcek changed the title Fix for sampler recompilations when using random sampler with batch_size padding Fix for random sampler recompilations for incomplete batches Dec 31, 2024
@mfylcek mfylcek marked this pull request as ready for review December 31, 2024 13:36
@mfylcek mfylcek marked this pull request as draft January 13, 2025 10:56
@mfylcek mfylcek marked this pull request as ready for review January 13, 2025 12:45
madamczykhabana
madamczykhabana approved these changes Jan 22, 2025
View reviewed changes
Copy link

@madamczykhabana madamczykhabana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mfylcek mfylcek merged commit e977f2a into habana_main Jan 22, 2025
32 checks passed
@mfylcek mfylcek deleted the dev/mfylcek/sampler-aware_batch_size_padding branch January 22, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madamczykhabana madamczykhabana madamczykhabana approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@michalkuligowski michalkuligowski Awaiting requested review from michalkuligowski michalkuligowski is a code owner

@mgawarkiewicz mgawarkiewicz Awaiting requested review from mgawarkiewicz mgawarkiewicz is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfylcek @madamczykhabana