-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added resume field in Application Page #103
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Deploy preview for irvinehacks-site-2024 ready!
|
Deploy preview for irvinehacks-site-2024-sanity ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this! A few questions/nitpicks:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock #93, we can revisit the actual design: currently not a fan of the "Successfully uploaded" text when it actually hasn't been uploaded.
* Created button and label * Minor style changes * Changed to correct html input element * Added error checking for file upload * Drag and drop works * Added visual indication for drag and drop * Moved output feedback to its own component * Made resume required * Removed drag and drop * Style changes * Form actually sends file with multipart * File is reset on page load * Removed unnecessary import from layout * Added to upload feedback * Update apps/site/src/app/apply/sections/Form/ResumeOutputFeedback.tsx Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Style changes to ResumeOutputFeedback * Added back action endpoint for form
Validation
Feedback
Form Change