Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resume field in Application Page #103

Merged
merged 18 commits into from
Dec 17, 2023
Merged

Added resume field in Application Page #103

merged 18 commits into from
Dec 17, 2023

Conversation

IanWearsHat
Copy link
Member

Validation

  • Form will prevent submission if:
    • File is not pdf
    • File is over 0.5 MB

Feedback

  • If any of the errors above occur, text will appear saying an error as occurred
  • If successful, text will appear saying so

Form Change

  • Changed form to be multipart to allow a file to be sent

@IanWearsHat IanWearsHat linked an issue Dec 16, 2023 that may be closed by this pull request
@IanWearsHat IanWearsHat requested a review from tyleryy December 16, 2023 21:34
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Dec 16, 2023

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 59da0db

Copy link
Contributor

github-actions bot commented Dec 16, 2023

Deploy preview for irvinehacks-site-2024-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 59da0db

Copy link
Contributor

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! A few questions/nitpicks:

samderanova
samderanova previously approved these changes Dec 17, 2023
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock #93, we can revisit the actual design: currently not a fan of the "Successfully uploaded" text when it actually hasn't been uploaded.

@IanWearsHat IanWearsHat merged commit 34534c2 into main Dec 17, 2023
4 checks passed
samderanova pushed a commit that referenced this pull request Dec 18, 2023
* Created button and label

* Minor style changes

* Changed to correct html input element

* Added error checking for file upload

* Drag and drop works

* Added visual indication for drag and drop

* Moved output feedback to its own component

* Made resume required

* Removed drag and drop

* Style changes

* Form actually sends file with multipart

* File is reset on page load

* Removed unnecessary import from layout

* Added to upload feedback

* Update apps/site/src/app/apply/sections/Form/ResumeOutputFeedback.tsx

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Style changes to ResumeOutputFeedback

* Added back action endpoint for form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add resume upload field to application form
3 participants