Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resume upload field improvements #116

Merged
merged 6 commits into from
Dec 18, 2023
Merged

Resume upload field improvements #116

merged 6 commits into from
Dec 18, 2023

Conversation

samderanova
Copy link
Contributor

@samderanova samderanova commented Dec 17, 2023 •
edited
Loading

Resolves #111 .

  • Made resume field optional
  • More accurate validation text ("selected" instead of "uploaded")
  • Changed icon to file icon instead of download icon

@samderanova samderanova requested a review from taesungh December 17, 2023 21:42
@samderanova samderanova linked an issue Dec 17, 2023 that may be closed by this pull request
Improve resume upload field #111
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 17, 2023 •
edited
Loading

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit d4e5c72

IanWearsHat
IanWearsHat previously approved these changes Dec 17, 2023
View reviewed changes
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry again for blocking.

taesungh
taesungh reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be adding the API handler for the empty octet stream since we aren't removing the file field on the client in #125 and didn't account for it in #128.

@samderanova samderanova force-pushed the update/resume-upload-improvements branch from f3ba74c to 9ab9477 Compare December 18, 2023 08:47
@samderanova
Resume upload field improvements:
803e285 
- Made resume field optional
- More accurate validation text ("selected" instead of "uploaded"
- Changed icon to file icon instead of download icon
@samderanova
feat: show green file uploaded icon on upload
3bdd1dd
@samderanova samderanova force-pushed the update/resume-upload-improvements branch from 9ab9477 to 3bdd1dd Compare December 18, 2023 08:49
taesungh and others added 3 commits December 18, 2023 00:57
@taesungh
Handle empty resume on API by checking zero size
d4e5c72 
- The browser will still provided an empty octet stream even when a file
  has not been selected
- If resume is provided but has no size, ignore file
@samderanova
feat: more styling for resume upload feedback
0439bbe
@samderanova
feat: third icon for invalid uploads
71dc252
@samderanova samderanova requested a review from taesungh December 18, 2023 10:26
taesungh
taesungh previously approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the different icons for each state.

apps/site/src/app/apply/sections/Form/ResumeOutputFeedback.tsx Show resolved Hide resolved
IanWearsHat
IanWearsHat reviewed Dec 18, 2023
View reviewed changes
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor text issue in the label

apps/site/src/app/apply/sections/Form/ResumeInformation.tsx Outdated Show resolved Hide resolved
IanWearsHat
IanWearsHat approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@IanWearsHat IanWearsHat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@samderanova samderanova merged commit 65ee82e into main Dec 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IanWearsHat IanWearsHat IanWearsHat approved these changes

@taesungh taesungh taesungh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve resume upload field
3 participants
@samderanova @taesungh @IanWearsHat