Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: redirect user from /apply to /portal #140

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

samderanova
Copy link
Contributor

Although the /apply route is already obscured from applicants who have already submitted an application and the backend prevents the resubmission of applications, applicants can still access the /apply page by directly navigating to it (i.e. typing in the URL search bar). If a user has already submitted an application, they should not be able to access the apply page again, so we should redirect them to /portal.

If a user has already submitted an application, they should not be able
to access the apply page again, so we should redirect them to /portal.
@samderanova samderanova requested a review from taesungh December 18, 2023 17:57
@samderanova samderanova linked an issue Dec 18, 2023 that may be closed by this pull request
Copy link
Contributor

Deploy preview for irvinehacks-site-2024 ready!

Name IrvineHacks 2024 Site
Preview Visit Preview
Commit 43d66d8

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't test entire application on preview since this was based after #137 but before #139, but redirect works purely based on status. Trusting this doesn't break the application itself. Do sometimes see a slight flash of footer coming up, maybe we need to revisit global min-height.

@samderanova samderanova merged commit f3f3e1e into main Dec 18, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redirect to /portal from /apply when user has already applied
3 participants