Refactor user roles from admin site to main site #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Create new enums for user roles for both the admin site and main site - Move status enums from `useApplicant` to the new `userRecord.ts` - Move `isNonHacker` check to `ParticipantAction` - The Portal still needs to be updated to use the new common enums
taesungh
force-pushed
the
refactor/user-record
branch
from
b9c09a1 to
4dba257
Compare
|
Deploy preview for irvinehacks-site-2025 ready!
|
IanWearsHat
approved these changes
Dec 23, 2024
IanWearsHat
added a commit
that referenced
this pull request
Dec 23, 2024
commit ab1d081 Author: Taesung Hwang <[email protected]> Date: Sun Dec 22 21:37:33 2024 -0800 Refactor user roles from admin site to main site (#519) - Create new enums for user roles for both the admin site and main site - Move status enums from `useApplicant` to the new `userRecord.ts` - Move `isNonHacker` check to `ParticipantAction` - The Portal still needs to be updated to use the new common enums commit c8e1d0c Author: Noah Kim <[email protected]> Date: Sun Dec 22 20:18:15 2024 -0800 Remove Three.js (#498) * update dependencies * Remove other unnecessary dependencies and directories * Minor refactor
IanWearsHat
added a commit
that referenced
this pull request
Dec 23, 2024
* Added route for getting hacker applicants * Added hacker applicants overview * -Moved admin functions to applicant_review_processor.py -Changed route to /applicants/hackers -Updated test_admin * Explicitly imported applicant_review_processor functions in test_admin * - scoped usage of functions from applicant_review_processor.py - renamed applicant_review_processor function names - moved applicant_review_processor unit tests to new file * - Added placeholder page at /applicants - Removed _omit_reviews - Reverted _process_batch - Moved all applicant_review_processor tests * Merged main into current branch (squash): commit ab1d081 Author: Taesung Hwang <[email protected]> Date: Sun Dec 22 21:37:33 2024 -0800 Refactor user roles from admin site to main site (#519) - Create new enums for user roles for both the admin site and main site - Move status enums from `useApplicant` to the new `userRecord.ts` - Move `isNonHacker` check to `ParticipantAction` - The Portal still needs to be updated to use the new common enums commit c8e1d0c Author: Noah Kim <[email protected]> Date: Sun Dec 22 20:18:15 2024 -0800 Remove Three.js (#498) * update dependencies * Remove other unnecessary dependencies and directories * Minor refactor * Changed enum for useHackerApplicants.ts * Revert "Changed enum for useHackerApplicants.ts" This reverts commit 0d3d887. * Revert "Merged main into current branch (squash):" This reverts commit 92eaa86. * deleted Applicants.tsx * Changed enum for useHackerApplicants.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using enums to represent the different possible user roles to have stronger named references.
Resolves #516. Will create a new issue about reorganizing how
Statusis used in the Applicant Portal.Changes
useApplicantto the newuserRecord.tsisNonHackercheck toParticipantAction