Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Admin] New hacker review logic and indicator #526

Merged
merged 10 commits into from
Dec 29, 2024
Merged

Conversation

IanWearsHat
Copy link
Member

@IanWearsHat IanWearsHat commented Dec 23, 2024

Part of #510

  • Insert document in MongoDB under settings collection similar to the following:
{
    _id: 'hacker_score_thresholds',
    accept: 8,
    waitlist: 5
}
  • Insert document in MongoDB under users collection similar to the following:
{
    _id: 'edu.uci.app22',
    application_data: {
        pronouns: [
            'he',
            'she'
        ],
        ethnicity: 'Two-or-more',
        is_18_older: false,
        school: 'UC San Diego',
        education_level: 'third-year-undergrad',
        major: 'Software Engineering',
        is_first_hackathon: false,
        linkedin: null,
        portfolio: null,
        frq_change: 'dsad',
        frq_video_game: 'dsa',
        email: '[email protected]',
        resume_url: null,
        submission_time: ISODate('2024-12-20T17:32:59.973Z'),
        reviews: [
            [
                ISODate('2024-12-20T17:41:22.634Z'),
                'edu.uci.ian4',
                4
            ],
            [
                ISODate('2024-12-20T17:42:01.098Z'),
                'edu.uci.ian5',
                10
            ]
        ]
    },
    first_name: 'dwa',
    last_name: 'sds',
    roles: [
        'Applicant',
        'Hacker'
    ],
    status: 'ACCEPTED'
}

All applicants overview

  • Navigate to /admin/applicants/hackers
  • Ensure that reviewer indicator works as expected.
    • Add 0, 1, and 2 reviewers in the application_data.reviews array and ensure that reviewer indicator correctly displays number of reviewers

Hacker applicant overview

  • Navigate to /admin/applicants/hackers
  • Click on the applicant card to navigate to that specific application
  • Submit score in top right input box
  • Ensure review log underneath updates correctly

New score encoding

  • Navigate to the specific application page /admin/applicants/(uid)
  • Change the "Hacker" string in the roles array in the mongo doc to "Mentor" or "Volunteer"
  • Ensure that the review action and the review log changes
  • Submit a review
  • Ensure that the correct review score is created in the mongo doc

- Added admin/release/hackers route for releasing hacker applicant decisions
- Added test for /review/hacker and /release/hackers
- Added hacker review logs in ApplicantOverview
- Added reviewer indicator in HackerApplicants.tsx
Copy link
Contributor

github-actions bot commented Dec 23, 2024

Deploy preview for irvinehacks-site-2025 ready!

Name IrvineHacks Site
Preview Visit Preview
Commit 9e55cfb

Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work so far, have an interesting thought about what the review system for the other types of applicants will look like. Thinking we could maybe combine some things instead of creating separate versions.

- Made StatusIndicator pending type
- Imported cloudscape components directly
- Moved useApplicant.ts to admin/applicants/hackers
- Made _retrieve_threshold function in admin.py
- Added comment for /admin/review/hacker route
- Moved review fields into a body model for /review/hacker and /review
…I is labelled differently based on app type

- Updated test_admin.py
- Fixed ApplicantReviewerIndicator
- Combined HackerApplicationReviews and ApplicationReviews
@IanWearsHat IanWearsHat requested a review from taesungh December 24, 2024 10:14
- Changed hackers route to return list of reviewers
- ApplicantReviewerIndicator displays uid of reviewer
@IanWearsHat IanWearsHat requested a review from waalbert December 25, 2024 01:52
-Moved comment to different line
@IanWearsHat IanWearsHat requested a review from waalbert December 25, 2024 08:24
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, some additional minor notes on little things that could be further improved.

- Returned full uid in _include_reviewers
- Changed query parameter name to update_query
- Changed decisionScores.ts to use numbers
- Used direct importing for HackerApplicantActions
- Removed hasReviewed prop
- Changed more than 2 reviewer error msg
- Renamed ReviewRequestModel
@IanWearsHat IanWearsHat requested a review from taesungh December 28, 2024 06:15
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to keep dragging along this PR, maybe note for next time that keeping things small would help with faster turnaround.

- Changed submitReview to use number parameter
- Fixed update applicant status check
Copy link
Member

@waalbert waalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for handling this big task Ian!

@waalbert waalbert merged commit 79a9a04 into main Dec 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants