-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Admin] New hacker review logic and indicator #526
Conversation
- Added admin/release/hackers route for releasing hacker applicant decisions - Added test for /review/hacker and /release/hackers
- Added hacker review logs in ApplicantOverview - Added reviewer indicator in HackerApplicants.tsx
Deploy preview for irvinehacks-site-2025 ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far, have an interesting thought about what the review system for the other types of applicants will look like. Thinking we could maybe combine some things instead of creating separate versions.
apps/site/src/app/admin/applicants/components/ApplicantReviewerIndicator.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/applicants/components/ApplicantReviewerIndicator.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/applicants/components/ApplicantReviewerIndicator.tsx
Outdated
Show resolved
Hide resolved
- Made StatusIndicator pending type - Imported cloudscape components directly - Moved useApplicant.ts to admin/applicants/hackers - Made _retrieve_threshold function in admin.py - Added comment for /admin/review/hacker route - Moved review fields into a body model for /review/hacker and /review
…I is labelled differently based on app type - Updated test_admin.py - Fixed ApplicantReviewerIndicator - Combined HackerApplicationReviews and ApplicationReviews
apps/site/src/app/admin/applicants/[uid]/components/HackerApplicantActions.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/applicants/components/ApplicantReviewerIndicator.tsx
Outdated
Show resolved
Hide resolved
- Changed hackers route to return list of reviewers - ApplicantReviewerIndicator displays uid of reviewer
apps/site/src/app/admin/applicants/[uid]/components/HackerApplicantActions.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/applicants/[uid]/components/HackerApplicantActions.tsx
Outdated
Show resolved
Hide resolved
-Moved comment to different line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good, some additional minor notes on little things that could be further improved.
apps/site/src/app/admin/applicants/components/ApplicantReviewerIndicator.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/applicants/components/ApplicantReviewerIndicator.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/app/admin/applicants/[uid]/components/HackerApplicantActions.tsx
Outdated
Show resolved
Hide resolved
- Returned full uid in _include_reviewers - Changed query parameter name to update_query - Changed decisionScores.ts to use numbers - Used direct importing for HackerApplicantActions - Removed hasReviewed prop - Changed more than 2 reviewer error msg - Renamed ReviewRequestModel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry to keep dragging along this PR, maybe note for next time that keeping things small would help with faster turnaround.
- Changed submitReview to use number parameter - Fixed update applicant status check
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for handling this big task Ian!
Part of #510
settings
collection similar to the following:users
collection similar to the following:All applicants overview
/admin/applicants/hackers
application_data.reviews
array and ensure that reviewer indicator correctly displays number of reviewersHacker applicant overview
/admin/applicants/hackers
New score encoding
/admin/applicants/(uid)