Fixing waiver handler and signing process #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for irvinehacks-site-2025 ready!
|
taesungh
reviewed
Jan 15, 2025
taesungh
reviewed
Jan 16, 2025
Comment on lines
+41
to
+43
| elif applicant_record.status == Status.ATTENDING: | ||
| log.warning(f"User {uid} has already signed the waiver and is attending.") | ||
| return |
There was a problem hiding this comment.
Sorry I missed this before, but I think this condition could be combined with the one before on line 36. For the future, might be worth considering somehow making Status a partially ordered set.
There was a problem hiding this comment.
It definitely could, I just thought that the warning message here is different enough to the previous one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #273 and #317