IH Schedule Page 2025 #581
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for irvinehacks-site-2025 ready!
|
IanWearsHat
requested changes
Jan 23, 2025
| import Sprite3 from "@/assets/images/volunteer_sprite.png"; | ||
|
|
||
| import styles from "./ShiftingCountdown.module.scss"; | ||
| import Image from "next/image"; |
There was a problem hiding this comment.
Chore (repeating): Reorder imports to libraries, custom components/functions, and then stylesheets.
apps/site/src/app/(main)/schedule/components/ShiftingCountdown/ShiftingCountdown.tsx
Show resolved
Hide resolved
| }} | ||
| /> | ||
| <div className="absolute top-[50%] right-14 max-md:hidden"> | ||
| <Image src={LgStar} alt="*" className="w-[70px] left-14" /> |
There was a problem hiding this comment.
suggestion: use more descriptive alt text
| return new Date(date.getFullYear(), date.getMonth(), date.getDate()); | ||
| } | ||
|
|
||
| // function getEventTomorrow(date: Date) { |
There was a problem hiding this comment.
chore: remove unused commented code
| return <EventCard key={event.title} now={now} {...event} />; | ||
| })} | ||
| </Tabs.Content> | ||
| <> |
There was a problem hiding this comment.
Chore: remove fragment and just return div
| function scrollDir(action: string) { | ||
| const ind = getCurrentDateIndex(); | ||
|
|
||
| if (action === "left") { |
There was a problem hiding this comment.
suggestion: last 2 lines of the if statement could be extracted out as they happen in both cases.
Also, you could then use a ternary operator to calculate nextIndex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft, IP items include