-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement guest authentication with passphrases #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Import `guest` router and `guest_auth` component from last year's HackAtUCI/HackUCI-Site repository as is
- Raise `RuntimeError` if `AUTH_KEY_SALT` environment variable is not provided to Vercel Serverless runtime - Reorganize environment variable usage and include note in API README
Deploy preview for irvinehacks-site-2024 ready!
|
Deploy preview for irvinehacks-site-2024-sanity ready!
|
taesungh
changed the title
Feature/guest auth
Implement guest authentication with passphrases
Dec 16, 2023
- For IrvineHacks 2024, we are allowing high school students (18+) who would not have .edu email addresses
taesungh
force-pushed
the
feature/guest-auth
branch
from
December 16, 2023 06:53
5d6bbe4
to
1ff9b76
Compare
- Replace `parse_obj` with `model_validate`
samderanova
approved these changes
Dec 16, 2023
Confirmed functional through |
rileysw
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add API routes and handlers for guest authentication. We currently don't have the frontend interface for guest login, so the authentication flow was tested manually with the FastAPI Swagger Docs and POST requests with curl.
Code Changes
guest
router andguest_auth
component from last year's HackAtUCI/HackUCI-Site repository as isEmailStr
usage intest_guest_auth
hackuci
withirvinehacks
AUTH_KEY_SALT
environment at runtimeRuntimeError
ifAUTH_KEY_SALT
environment variable is not provided to Vercel Serverless runtimeparse_obj
withmodel_validate
Deployment Changes
AUTH_KEY_SALT
to Vercel deploymentsTesting
http://localhost:8081
http://localhost:8000/docs
/guest/login
and then/guest/verify