feat: enable application submission #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for irvinehacks-site-2024 ready!
|
|
Deploy preview for irvinehacks-site-2024-sanity ready!
|
taesungh
reviewed
Dec 16, 2023
There was a problem hiding this comment.
This will work for now. However keep in mind that it would be better to have client-side error handling in case anything goes wrong during the form submission in which case we would need to use event.preventDefault and then send the POST request ourselves with axios or alike.
taesungh
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not entirely resolve #90 but takes a step towards doing so using native POST (instead of
axiosPOST which we can use for error handling).