Updated Knex version and added migrations directory for managing data… #1
Conversation
| * @returns { Promise<void> } | ||
| */ | ||
| exports.up = function (knex) { | ||
| return knex.schema.createTable('Teams', (table) => { |
There was a problem hiding this comment.
I will not use uppercase letter for table names. It's generally recommended to use lowercase letters for table names to ensure consistency and compatibility across different environments and database systems.
| * @returns { Promise<void> } | ||
| */ | ||
| exports.up = function (knex) { | ||
| return knex.schema.hasTable('TeamMembers').then((exists) => { |
There was a problem hiding this comment.
Do you guys really need this table? Maybe employees table could have another column.
There was a problem hiding this comment.
The purpose of this TeamMembers table is to keep records of the team members, as well as to make it easy to record if one person becomes a part of a different team in the future.
There was a problem hiding this comment.
Ok, I understand now.
Maybe you guys need to add some foreign keys here as well 🤔
What do you think @nishadipri @SpartanDeBoss ?
| @@ -0,0 +1,28 @@ | |||
| // const mysql = require('mysql'); | |||
There was a problem hiding this comment.
Why is all of this being commented out? Is the file needed or not?
There was a problem hiding this comment.
Why is all of this being commented out? Is the file needed or not?
I was supposed to delete that, but unfortunately, I forgot it and then pushed it. @orhantoy
…base schema changes
Description
Please provide a short summary explaining what this PR is about.
Fixes # (issue)
How to test?
Please provide a short summary how your changes can be tested?
Checklist