Create team page #3
Conversation
…base schema changes
| if (!exists) { | ||
| return knex.schema.createTable('TeamMembers', (table) => { | ||
| table.increments('id').unsigned().primary(); | ||
| table.integer('team_id').unsigned().notNullable(); |
There was a problem hiding this comment.
I think you are missing something on this line.
| return knex.schema.createTable('TeamMembers', (table) => { | ||
| table.increments('id').unsigned().primary(); | ||
| table.integer('team_id').unsigned().notNullable(); | ||
| table.integer('employee_id').unsigned().notNullable(); |
There was a problem hiding this comment.
I also think you are missing something here.
| // }); | ||
| // } | ||
|
|
||
| // connectToDatabase(); |
There was a problem hiding this comment.
Why is this file commented out?
| @@ -16,6 +16,8 @@ module.exports = { | |||
| directory: path.join(__dirname, '/seeds/development'), | |||
| }, | |||
| }, | |||
| // Existing code... | |||
| function CreateTeam() { | ||
| const [teamName, setTeamName] = useState(''); | ||
| const [firstName, setFirstName] = useState(''); | ||
| const [lastName, setLasttName] = useState(''); |
There was a problem hiding this comment.
I think you have a typo in the setter
| const [lastName, setLasttName] = useState(''); | ||
| const [email, setEmail] = useState(''); | ||
| const [teamMembers, setTeamMembers] = useState([]); | ||
| const [employees] = useState([ |
There was a problem hiding this comment.
You could just do it like this:
| const [employees] = useState([ | |
| const employees = [<!-- data -->] |
| email, | ||
| }; | ||
|
|
||
| teamMembers.push(newMember); |
There was a problem hiding this comment.
When adding new members to the team, you directly manipulate the DOM with teamMembers.push(). React prefers immutability, so it's better to create a new array and then update the state.
| } | ||
| }; | ||
|
|
||
| const addExcistingMember = (e) => { |
There was a problem hiding this comment.
I've left a few comments for you.
As I recommended earlier, it would be beneficial to break PRs into smaller ones. For instance, having a separate PR for adding the migrations and another for CreateTeamPage. Additionally, consider breaking down the component into smaller components to better separate concerns.
Description
This pull request introduces the CreateTeamPage component, allowing users to create new teams. Key features include:
Form Input:
Users can input a team name and add team members by providing their details or selecting existing employees.
Validation and Alerts:
The form includes validation checks and alerts for missing information or duplicate team members.
Dynamic Member List:
Added team members dynamically appear below the form for easy management.
How to test?
use the command "npm start"