validate team code #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shpomp
requested changes
Apr 21, 2024
| const results = await knex('Teams').where({ team_code: teamCode }); | ||
|
|
||
| if (results.length === 0) { | ||
| throw new Error('Team not found'); |
There was a problem hiding this comment.
Perhaps would be better to not throw an error, but to send a response with 404 code?
There was a problem hiding this comment.
we have something like this when user enter the wrong code
There was a problem hiding this comment.
I saw this, but I mean in terms of the API, it is perhaps not the best to throw an error here, because and error did not happen.
"The HTTP 404 Not Found response status code indicates that the server cannot find the requested resource."
…etroRealm into implementIndexPage
shpomp
approved these changes
Apr 22, 2024
| const results = await knex('Teams').where({ team_code: teamCode }); | ||
|
|
||
| if (results.length === 0) { | ||
| throw new Error('Team not found'); |
There was a problem hiding this comment.
I saw this, but I mean in terms of the API, it is perhaps not the best to throw an error here, because and error did not happen.
"The HTTP 404 Not Found response status code indicates that the server cannot find the requested resource."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implemented team code validation
Fixes # (issue)
How to test?
Please provide a short summary how your changes can be tested?
Checklist