Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Preserve topic repos #723

Closed
wants to merge 3 commits into from
Closed

Conversation

MattIPv4
Copy link
Member

@MattIPv4 MattIPv4 commented Nov 2, 2020

Description

Create PreservedTopicPR which will contain all PR IDs that were in the waiting state prior to Hf ending.

Skip the repository topic check for a PR if it is in the preserved list.

Rake task to restore PRs back into the waiting state if they became invalid due to the topic being removed after Hf ended.

Rake task to restore users back into the correct state if their invalid PRs caused them to lose.

Test process

This is absolutely untested, good luck.

Requirements to merge

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@MattIPv4
Copy link
Member Author

MattIPv4 commented Nov 4, 2020

After discussion with whole dev team, we have all agreed the user transitions involved are too risky.

@MattIPv4 MattIPv4 closed this Nov 4, 2020
@hpoul
Copy link

hpoul commented Nov 4, 2020

does this mean it's just bad luck if the topic was removed from a repository, or is there a workaround without bothering the project admin to reapply the topic 🤔️

@cy
Copy link

cy commented Nov 5, 2020

does this mean it's just bad luck if the topic was removed from a repository, or is there a workaround without bothering the project admin to reapply the topic 🤔️

Even if the maintainer reapplies the topic, the PRs do not become invalidated, see the discussion in python/typeshed#4631 for an example. Unfortunately, I think all of us sad about this have no workaround since #723 was closed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants