Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve camera source error handling and fallback mechanism #330

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

8thgencore
Copy link
Contributor

Description & motivation

This pull request aims to enhance the robustness and reliability of our camera setup processes by adding comprehensive error handling for both multi-camera and single camera configurations. It includes the implementation of a fallback mechanism to a single camera source in case the multi-camera setup fails, logging of detailed error messages for various scenarios, and ensuring graceful handling of camera permission and initialization errors. These changes are critical for improving the user experience and system stability.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add comprehensive error handling for multi-camera and single camera setups
  • Implement fallback to single camera source if multi-camera initialization fails
  • Log detailed error messages for different camera setup scenarios
  • Ensure graceful handling of camera permission and initialization errors

- Add comprehensive error handling for multi-camera and single camera setups
- Implement fallback to single camera source if multi-camera initialization fails
- Log detailed error messages for different camera setup scenarios
- Ensure graceful handling of camera permission and initialization errors
Copy link
Collaborator

@shogo4405 shogo4405 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree; I think this one might be better. Thanks.

@shogo4405 shogo4405 merged commit 285a05f into HaishinKit:main Mar 4, 2025
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants