Verify map exception leak fix #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 4, 2024 13:31
…, added cleanup_textures() call in panic branch. Fixed panic_clean() in get_textures_utils() not properly iterating through all the indexes in textures->text_paths. Replaced magic index number in parser.h in textdata arrays with proper macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed leak from textdata by calling cleanup_textures in parse_map() when verify_map() would return PANIC.
Changed cleanup_textures() from static to globally accessible from parser.h.
Fixed leak from get_textures_info() caused by panic_clean() in get_textures_util() being hardcoded to iterate over 4 buffers of the textdata struct, missing one. Changed magic index numbers in textdata struct buffers in parser.h to use proper macro for readability.