Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minishell version 0.1 #23

Merged
merged 37 commits into from
Jul 15, 2024
Merged

Minishell version 0.1 #23

merged 37 commits into from
Jul 15, 2024

Conversation

Haliris
Copy link
Owner

@Haliris Haliris commented Jul 13, 2024

Can process most commands and redirections combinations I could think of, without memory issues.

O_APPEND (>>) and the here_doc (<<) are not implemented, I will work, on it later today.

Not much thought put into error handling, other than not exiting from the program when a child would throw an error.

Issues that have been resolved #21

Jean Teissier and others added 20 commits July 12, 2024 18:41
… fork in main process to separate execuion from the main process
…x equal to the cmd_count so that the first command does not listen to an empty pipe and executes correctly. Build works for one commands, pipes need to be fixed
@Haliris Haliris added the Do not merge Something isn't working label Jul 13, 2024
@Haliris Haliris marked this pull request as ready for review July 15, 2024 13:07
@Haliris Haliris requested a review from BenjaminHThomas July 15, 2024 13:07
@Haliris Haliris changed the title WIP: Version 0.1 Minishell version 0.1 Jul 15, 2024
@Haliris Haliris added Ready for merge and removed Do not merge Something isn't working labels Jul 15, 2024
Copy link
Collaborator

@BenjaminHThomas BenjaminHThomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenjaminHThomas BenjaminHThomas merged commit 7f44021 into main Jul 15, 2024
4 checks passed
@Haliris Haliris deleted the beta_build branch July 15, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues regarding version 0.1, more of a todo list
2 participants