-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minishell version 0.1 #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tes through tokens
…sting and call of parsed_tableaddback()
…criptors function
… fork in main process to separate execuion from the main process
… rejoin_str from get_next_line
…x equal to the cmd_count so that the first command does not listen to an empty pipe and executes correctly. Build works for one commands, pipes need to be fixed
…ecution since they get changed by the exec process
… need to refactor to open ALL redirection files, but only keep the last one.
…licates their fds, to patch issue with redirections ending with /dev/stdout
…eeed with further testing
…ll children to finish
BenjaminHThomas
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can process most commands and redirections combinations I could think of, without memory issues.
O_APPEND (>>) and the here_doc (<<) are not implemented, I will work, on it later today.
Not much thought put into error handling, other than not exiting from the program when a child would throw an error.
Issues that have been resolved #21