-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds handling of >> and << redirections. #28
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TER the execution processes are done. Also fixed bad parsing of heredoc tokens. Execution does not work, it receives a bad file descriptor
…h heredoc as redirection in, untraceable
…hild can now reopen it, modified parser logic and execution logic to reflect that change. added protection to parser_clean exit logic to avoid calling free on the heredoc path.
… and unlink functions. Append does not work sometimes, yet to be traced
…preference to the >> operator due to strncmp stopping too early for shorter strings
Spotted a bug with <<, do not merge |
Wait no I am dumb, I was testing on main |
BenjaminHThomas
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minishell can now handle here_doc and append redirections properly..
Added here_doc utils function in main and here_doc_utils.c files to duplicate adresses to the here_doc files path and unlink() them after execution.
Parser now distributes TK_PARS_APPEND tokens to files that need to be appended, no change in logic for here_doc, they are treated the same as normal files.