Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gravity hammer balance and ODST call in fix #3541

Merged
merged 10 commits into from
Feb 23, 2024

Conversation

OuterMostMonk
Copy link

@OuterMostMonk OuterMostMonk commented Feb 18, 2024

Attempts to make the powered gravity hammer useable but not too strong. Also fixes ODSTs having more than just personalised call ins.
Hopefully could lead to Chieftain being enabled in the future whether as an alternative to shipmaster or as an extra.

🆑 OuterMonk
tweak: Powered gravity hammer no longer spammable, hunters immune to its knockback.
tweak: Non officer ODSTs get personalised call downs only
/:cl:

Makes the powered hammer less broken by preventing killing enemies by clicking as fast as possible. Prevents instant door breaking and pushing back of hunters with it.
Sets the max armour properly so chieftains don't seem to have 200% armour displayed when examined.
Gives chieftain job its hammer back (Since it hopefully should not be busted now)
Normal ODSTs were able to call down medical and other supplies they shouldn't. They are only intended to have personalised drops.
Officers retain their current support options.
Adds a check I forgot to put in. To stop direct hits moving the hunter.
@OuterMostMonk OuterMostMonk requested a review from a team as a code owner February 18, 2024 05:04
@@ -265,23 +266,26 @@
return

var/atom/throw_target = get_edge_target_turf(A, get_dir(user, A))
if(istype(A, /atom/movable))
if(istype(A, /atom/movable) && !istype(A, /obj/machinery/door) && !istype(A, /mob/living/simple_animal/mgalekgolo)) //No instant door breaking or bullying poor hunters
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could probably just be narrowed down to only shift /mob/living and /obj/item/

X0-11
X0-11 previously requested changes Feb 18, 2024
for(var/atom/movable/M in range(A,1))
if(M == user)
continue
if((world.time-timer)>29) // To avoid spamming non direct hits
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a define instead of a magic number like this.

if(M == user)
continue
if((world.time-timer)>29) // To avoid spamming non direct hits
timer = world.time + 30
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The define can be used here too.

Attempts to make the code less messy
No wonder it was failing
@OuterMostMonk
Copy link
Author

Changes made, should be better now (I hope). I kept hunters immune with the narrowing down of targets but wonder if complete immunity is too much. Maybe I should allow them to be moved by the ground attack which has a cooldown but not direct attacks?

@X0-11
Copy link
Collaborator

X0-11 commented Feb 19, 2024

I think keeping hunters immune is fine as-is, although you may want to check through the code and see if there's some internal size tracking for simplemobs that you can check against rather than specifically targeting hunters, as flood juggernauts should also probably be immune.

For use with checks in the hammer (couldn't find any existing ways to check if the mob is large)
Should prevent both Juggernauts and Hunters from being thrown by the hammer (And any other mob with a large size)
@OuterMostMonk
Copy link
Author

Large size mobs are now immune to gravity hammer knockback. Not sure what other mobs count as large but I imagine for halo mobs it is just juggernaut and hunter.

@BDpuffy420 BDpuffy420 merged commit bd111d9 into HaloSpaceStation:alpha Feb 23, 2024
18 checks passed
hs-cicero added a commit that referenced this pull request Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants