Skip to content

Commit

Permalink
Use data-qa-id instead for locale support (berrberr#549)
Browse files Browse the repository at this point in the history
* Use data-qa-id instead for locale support

The current aria-label is locale dependent, which causes some buttons to be unavailable.
the data-qa-id is locale independent and unique within the ControlsContainer.

* Removed single quotes
  • Loading branch information
JoostvdB94 authored and berrberr committed Dec 31, 2019
1 parent 58b69a6 commit c63b3a0
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions code/js/controllers/PlexController.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,11 @@

var controller = new MouseEventController({
siteName: "Plex.tv",
play: "div[class^=ControlsContainer] button[aria-label=Play]",
pause: "div[class^=ControlsContainer] button[aria-label=Pause]",
playNext: "div[class^=ControlsContainer] button[aria-label=Next]",
playPrev: "div[class^=ControlsContainer] button[aria-label=Previous]",
mute: "div[class^=ControlsContainer] button[aria-label$='ute Volume']",
play: "div[class^=ControlsContainer] button[data-qa-id=resumeButton]",
pause: "div[class^=ControlsContainer] button[data-qa-id=pauseButton]",
playNext: "div[class^=ControlsContainer] button[data-qa-id=nextButton]",
playPrev: "div[class^=ControlsContainer] button[data-qa-id=previousButton]",
mute: "div[class^=ControlsContainer] button[data-qa-id=volumeButton]",

song: "title",
buttonSwitch: true
Expand Down

0 comments on commit c63b3a0

Please sign in to comment.