Add support for debugging aliasing problems in GPU hangs #1150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansKristian-Work
force-pushed
the
placed-alias-debug
branch
from
598fae0 to
3d1de5d
Compare
HansKristian-Work
changed the title
The old path is completely untested at this point, and I found a bug with root descriptors since we don't do the proper deref to obtain proper VA anymore, so that would have crashed GPUs hard ... Removes a lot of old jank code. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
To be used for inline UBO replacement. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Make push descriptors a required feature. It's widely supported now that amdvlk enabled it. The min spec of push descriptors is 32 descriptors which means we never have to fall back. The D3D12 spec supports 32 root descriptors. When we have that many root descriptors, we never risk running out of push constant space, so there won't be a need for fallback UBO. Tweak the hoisting logic a little bit to make sure we never overflow the 32 push desc min-spec. Replace inline UBO (not compatible with push descriptors) with push UBO for fallback data. This path should basically never be hit anyways. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
HansKristian-Work
force-pushed
the
placed-alias-debug
branch
2 times, most recently
from
942e707 to
a4711d2
Compare
Report any placed aliases which could cause issues. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Report resource cookies so that it's easier to track down aliasing issues. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Replays relevant commands in submission order. Signed-off-by: Hans-Kristian Arntzen <[email protected]>
HansKristian-Work
force-pushed
the
placed-alias-debug
branch
from
a4711d2 to
0d81c1e
Compare
Useful mostly for debug so we acknowledge there was a discard command (except we cannot transition). Signed-off-by: Hans-Kristian Arntzen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.