Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamecube NTSC JP Support #510

Open
wants to merge 30 commits into
base: develop
Choose a base branch
from

Conversation

inspectredc
Copy link
Contributor

@inspectredc inspectredc commented May 27, 2024

Since GitHub Refuses to let me re-open my old PR #159 I'll just make a new one here

Original Description:

This pretty much has the same to do list as #155 :

  • More testing: I have checked the intro cutscene and messed around in termina field and clock town so far, but not much else
  • Figuring out how to link the externalfile code/actor and renaming the file to something more appropriate
  • Wait for asset headers to be committed or implement asset header extraction to write to the correct directory
    - [ ] Add uncompressed rom hashes to the relevant places
  • Transfer over xml changes from other PRs
  • Audio

Build Artifacts

mckinlee pushed a commit to mckinlee/2ship2harkinian that referenced this pull request Sep 23, 2024
@Wham-Ba
Copy link

Wham-Ba commented Feb 4, 2025

I'm not sure how helpful this will be, but I've tested at least up to the middle of the first dungeon.

Issues I've noticed:

  • The 'Press Start' message at the title screen is displayed instead as a jumble of nonsensical Japanese characters.
  • Using the 'Skip to File Select' option found in the 'Enhancements --> Cutscenes' section causes the File Select menu to be bugged. It seems to load the English characters for file names instead of Japanese characters.
  • (Not sure if this happens on original hardware) When a character mentions your File Name during dialogue, there are a series of blank spaces after your name that presumably correspond to the maximum number of characters a File Name can have. In other words, your name takes up the same amount of space whether it's made of one character or eight. This happens for example, when getting the Bomber's Notebook.
  • When you obtain as item where Link holds it up over his head and text displays, the first line of each textbox is placed too far to the left and often overlaps the item's icon if present.
  • When you receive the Dungeon Map, the mini-map in seriously bugged and displays as garbled pixels of white.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants