Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and fix vanilla bug with smoke rendering #997

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

Archez
Copy link
Contributor

@Archez Archez commented Feb 16, 2025

Documents and fixes an incorrect gfx setup call used for the chimney smoke effects. The setup was run on OPA when the actor is actually rendered on XLU. This means the gfx would inherit setup from the previous XLU actor.

In the case of Romani Ranch at night during the Aliens attack start cutscene, the UFO lens flare renders right before the smoke and causes it to appear in bright white when its alpha should be close to 0. Most likely there is floating point precision differences that prevents this from occurring on console (the smoke effect has a check for > 0.0f to even render in the first place).

I've opted to fix the gfx setup to address the smoke effect in the Aliens cutscene.

The Stock Pot Inn had the same bug, so I opted to fixed that too.

Build Artifacts

@Archez Archez merged commit 5a06467 into HarbourMasters:develop Feb 21, 2025
5 checks passed
@Archez Archez deleted the fix-chimney-smoke branch February 21, 2025 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant