Document and fix vanilla bug with smoke rendering #997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents and fixes an incorrect gfx setup call used for the chimney smoke effects. The setup was run on OPA when the actor is actually rendered on XLU. This means the gfx would inherit setup from the previous XLU actor.
In the case of Romani Ranch at night during the Aliens attack start cutscene, the UFO lens flare renders right before the smoke and causes it to appear in bright white when its alpha should be close to 0. Most likely there is floating point precision differences that prevents this from occurring on console (the smoke effect has a check for > 0.0f to even render in the first place).
I've opted to fix the gfx setup to address the smoke effect in the Aliens cutscene.
The Stock Pot Inn had the same bug, so I opted to fixed that too.
Build Artifacts