Fix Gerudo Valley entrance logic

[serprex]

Logic assumed cucco could be used as child to get around lacking bronze scale,
but this assumption fails if you enter grotto ledge from grotto or initial spawn

This updates logic with following:

1. Adult can only get across to upper stream by either taking damage or having bronze scale
2. Child reaches Lake Hylia with cucco from top of cliff, never any other location
3. Adult can walk to Lake Hylia from lower stream with iron boots
4. It is possible to get from grotto ledge to upper stream, put behind trick logic (note explosive not really needed, an accurate sidehop will do)

Build Artifacts

• soh-linux.zip
• soh-windows.zip
• soh-mac.zip

[Malkierian]

I think I understand the reasoning for adding Lake Hylia as exits to RR_GERUDO_VALLEY. Does a check for bronze scale need to be added to RR_GV_CRATE_LEDGE and GROTTO_LEDGE going to lower stream as well?

[serprex]

@Malkierian I messed up a bit, the trick sidehop is to get from grotto ledge to upper stream. Copied logic from crate ledge to grotto ledge. The key to the issue this PR fixes is that lower stream should unconditionally require bronze scale to reach lake hylia, as it isn't safe to assume child can have cucco there

Could logically trace cucco access, but much more straightforward to lift any cucco usage to the location child picks up cucco

[Malkierian]

Honestly, that looks like you made it worse, for what I was mentioning. Having child cucco access to either of the ledges doesn't guarantee that you'll still have the cucco to get past lower, and it looks like there are instances you could get access to either without passing through RR_GERUDO_VALLEY (especially with mixed pools/decoupled entrances), so I still think that any region that has an entrance pointing to lower stream should have a bronze scale check on that entrance.

[Archez]

LOWER_STREAM contains the exit to LH with a bronze check, everything else points to LOWER_STREAM, why does there need to be a second bronze check on them? There is nothing else in LOWER_STREAM that would require the bronze check to happen earlier.

If child has access to the HF side of GV to get to the ledges, then they already satisfied the GV -> LH via cucco access.

[Malkierian]

Well that then also becomes a problem for me, because that assumes the player holds onto the cucco through all paths prior to technically reaching lower stream, but again, with entrance shuffle, it's possible to get to regions between GV and lower stream without passing through GV first, so cucco access can't be guaranteed at the ledges.

[Malkierian]

Well that then also becomes a problem for me, because that assumes the player holds onto the cucco through all paths prior to technically reaching lower stream, but again, with entrance shuffle, it's possible to get to regions between GV and lower stream without passing through GV first, so cucco access can't be guaranteed at the ledges.

In order to truly resolve this, I still firmly believe, at the very least, IsChild should be removed from RR_GV_LOWER_STREAM's LH entrance, especially since we have the new exit from the top GV region directly to LH. Otherwise, logic could think you can pop out of the grotto entrance as child and still make it to LH.

[Archez]

Well that then also becomes a problem for me, because that assumes the player holds onto the cucco through all paths prior to technically reaching lower stream, but again, with entrance shuffle, it's possible to get to regions between GV and lower stream without passing through GV first, so cucco access can't be guaranteed at the ledges.

In order to truly resolve this, I still firmly believe, at the very least, IsChild should be removed from RR_GV_LOWER_STREAM's LH entrance, especially since we have the new exit from the top GV region directly to LH. Otherwise, logic could think you can pop out of the grotto entrance as child and still make it to LH.

This is what is in the PR diff currently.