Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Gerudo Fortress #5099

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from

Conversation

Pepe20129
Copy link
Contributor

@Pepe20129 Pepe20129 commented Feb 26, 2025

Splits the current RR_GERUDO_FORTRESS region into multiple regions in order to untangle logic.
The rooftops are named by color (included clarifying images).

Build Artifacts

Comment on lines +59 to +61
!soh/soh/Enhancements/randomizer/location_access/gerudo_fortress_regions.png
!soh/soh/Enhancements/randomizer/location_access/gerudo_fortress_regions_no_labels.png

Copy link
Contributor

@serprex serprex Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
!soh/soh/Enhancements/randomizer/location_access/gerudo_fortress_regions.png
!soh/soh/Enhancements/randomizer/location_access/gerudo_fortress_regions_no_labels.png

think these paths are wrong given this is one level deep

@serprex
Copy link
Contributor

serprex commented Feb 27, 2025

-1 to basing names colors in arbitrary image

Some descriptive name suggestions:

  • Salmon: OUTSIDE_GTG
  • White: ABOVE_GTG
  • Purple: BELOW_VINES
  • Blue: ABOVE_VINES (or TOP_PLATFORM but ambiguous with chest platform)
  • Turquoise: CHEST_PLATFORM
  • Green: GS_DIP or GS_PLATFORM, not sure what to call green bit with door
  • Red: OUTSIDE_JAIL
  • Yellow: OUTSIDE_KITCHEN
  • Lime green: BELOW_CHEST
  • Magenta: BELOW_GS_DIP or BELOW_GS_PLATFORM
  • Orange: BEHIND_CRATES
  • Violet: can this not be combined with either ABOVE_VINES or BELOW_VINES? Looking at logic you seem to miss Blue->Violet being free. ISLAND_BELOW_VINES?
  • Cyan: DIP_BELOW_VINES
  • Grey: ABOVE_STAIRS

@Pepe20129
Copy link
Contributor Author

I'd also like to have actual names instead of colors but we haven't found a good set yet.
Regarding your suggestions:

  • BELOW_VINES, ABOVE_VINES & DIP_BELOW_VINES are ambiguous as there are 2 vines (one between purple & blue and one between lime & cyan)
  • GS_DIP & GS_PLATFORM only describe half of the green area, both spots/ledges are the same area.
  • OUTSIDE_KITCHEN should be OUTSIDE_BREAK_ROOM but is otherwise fine
  • BELOW_CHEST is ambiguous between yellow & lime green
  • BEHIND_CRATES is ambiguous between orange & grey depending on which crates (and depending on from which direction, it could also be red)
  • violet can't be combined with blue as violet->blue can only be done as adult (I did miss blue->violet, ty for that)
  • ISLAND_BELOW_VINES doesn't seem like a good name, not only because of the 2 vines, but also because naming it island is not very intuitive
  • OUTSIDE_JAIL is a little unintuitive due to the large height change but I think it's a fine name if we don't come up with anything better
  • The rest (OUTSIDE_GTG, ABOVE_GTG, CHEST_PLATFORM & ABOVE_STAIRS) are fine and I have no problems with them

@serprex
Copy link
Contributor

serprex commented Feb 27, 2025

Oh, wasn't sure about 2nd vines. But that helps even more, since names can be around LOWER_VINES & UPPER_VINES

@serprex
Copy link
Contributor

serprex commented Feb 27, 2025

Good: Salmon: OUTSIDE_GTG, White: ABOVE_GTG, Turquoise: CHEST_PLATFORM, Yellow: OUTSIDE_BREAK_AREA, Grey: ABOVE_STAIRS

Enough for now: Red: OUTSIDE_JAIL

Adjusted for vines:

  • Purple: BELOW_UPPER_VINES
  • Blue: ABOVE_UPPER_VINES
  • Lime green: BELOW_LOWER_VINES
  • Cyan: ABOVE_LOWER_VINES

Left: Green, Magenta, Orange, Violet

I'll try some more suggestions, but these 4 are rough

  • Orange: CRATE_ALCOVE
  • Purple: PLATFORM_IN_CORNER_BELOW_PLATFORM_ABOVE_UPPER_VINES, PLATFORM_ACROSS_FROM_PLATFORM_BELOW_UPPER_VINES (the adult/child distinction from Violet only matters to logic if the player can't climb to blue, ie in the future when Shuffle Climb is a thing)
  • Magenta: not sure, may clear up once name for Green is settled on
  • Green: HIGHEST_DOOR_AND_BELOW_GS

(edit: also overlooked Lime Green, maybe LONG_PLATFORM_BELOW_CHEST)

@Pepe20129
Copy link
Contributor Author

I think that BELOW_UPPER_VINES, ABOVE_UPPER_VINES, BELOW_LOWER_VINES & ABOVE_LOWER_VINES are good names.
CRATE_ALCOVE is fine for now (maybe CRATE_GROUND_ALCOVE?).
The other ones do need more work but I don't think there are any good short descriptive names for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants