Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional tweak to penalize player score for Friendly Fire on Katina #77

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Kiloku
Copy link
Contributor

@Kiloku Kiloku commented Dec 27, 2024

This adds an optional tweak that causes players to lose points when they shoot down allies in Katina.
It's set to off by default.
I've made sure to prevent underflowing (it checks if your score is bigger than zero before trying to subtract)

As an added bonus, this fixes a bug with the Score Editor, which would spin like crazy if you set the value to lower than the current score.

Screenshot from 2024-12-26 20-58-27

Screencast.from.12-26-2024.08.59.56.PM.mp4

@sonicdcer
Copy link
Collaborator

This is a mod, i suggest you add a Mods category in between Cheats and Developer for it.

@Kiloku
Copy link
Contributor Author

Kiloku commented Dec 27, 2024

image
Done

@FitzRoyX
Copy link

Yes, notice that the existing enhancements are objective while yours is subjective. Dynamic polygon reduction is almost fully negative now: more visible at high resolutions without raising fps the way it did in the past.

If subjective mods get accepted in their own category, the only concern would be how many will be added in the future. There are thousands of places where you could say "this design mechanic should be like this because I think it's better." But this generally only makes sense when it is a common complaint among the playerbase.

@Kiloku
Copy link
Contributor Author

Kiloku commented Dec 27, 2024

I'm going with whatever the project's maintainers say. If minor mods in a dedicated Mods menu are okay, then I'm submitting them. That's what Sonic said to do, so I did it.

I imagine it's also the only way to make such minor mods easily accessible to players. Unless there's some way to make code mods work without requiring binary patching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants