isEmpty return true for null | undefined

Harris-Miller · Jun 18, 2024 · 6e3a8ac · 6e3a8ac
1 parent 980b3bf
commit 6e3a8ac
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 13 deletions.
diff --git a/dist/ramda.js b/dist/ramda.js
@@ -6155,7 +6155,7 @@
    *      R.isEmpty(Uint8Array.from('')); //=> true
    */
   var isEmpty = _curry1(function isEmpty(x) {
-    return x != null && equals(x, empty(x));
+    return x != null || equals(x, empty(x));
   });
 
   /**

diff --git a/dist/ramda.min.js b/dist/ramda.min.js
diff --git a/package-lock.json b/package-lock.json
diff --git a/source/isEmpty.js b/source/isEmpty.js
@@ -26,6 +26,6 @@ import equals from './equals.js';
  *      R.isEmpty(Uint8Array.from('')); //=> true
  */
 var isEmpty = _curry1(function isEmpty(x) {
-  return x != null && equals(x, empty(x));
+  return x == null || equals(x, empty(x));
 });
 export default isEmpty;
diff --git a/test/isEmpty.js b/test/isEmpty.js
@@ -4,12 +4,12 @@ var eq = require('./shared/eq.js');
 
 describe('isEmpty', function() {
 
-  it('returns false for null', function() {
-    eq(R.isEmpty(null), false);
+  it('returns true for null', function() {
+    eq(R.isEmpty(null), true);
   });
 
-  it('returns false for undefined', function() {
-    eq(R.isEmpty(undefined), false);
+  it('returns true for undefined', function() {
+    eq(R.isEmpty(undefined), true);
   });
 
   it('returns true for empty string', function() {

diff --git a/test/isNotEmpty.js b/test/isNotEmpty.js
@@ -4,12 +4,12 @@ var eq = require('./shared/eq.js');
 
 describe('isNotEmpty', function() {
 
-  it('returns true for null', function() {
-    eq(R.isNotEmpty(null), true);
+  it('returns false for null', function() {
+    eq(R.isNotEmpty(null), false);
   });
 
-  it('returns true for undefined', function() {
-    eq(R.isNotEmpty(undefined), true);
+  it('returns false for undefined', function() {
+    eq(R.isNotEmpty(undefined), false);
   });
 
   it('returns false for empty string', function() {