-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rpc implementation [part 2/5] #2
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabadesso
changed the title
feat: rpc implementation
feat: rpc implementation [part 1/?]
Jun 19, 2024
andreabadesso
changed the title
feat: rpc implementation [part 1/?]
feat: rpc implementation [part 1/4]
Jun 19, 2024
andreabadesso
changed the title
feat: rpc implementation [part 1/4]
feat: rpc implementation [part 2/4]
Jun 19, 2024
andreabadesso
changed the title
feat: rpc implementation [part 2/4]
feat: rpc implementation [part 2/5]
Jun 19, 2024
andreabadesso
force-pushed
the
feat/rpc-implementation
branch
2 times, most recently
from
June 20, 2024 23:38
996747f
to
a584b37
Compare
andreabadesso
force-pushed
the
feat/rpc-implementation
branch
2 times, most recently
from
July 12, 2024 13:41
3ef1589
to
aa16590
Compare
andreabadesso
force-pushed
the
feat/rpc-implementation
branch
from
July 12, 2024 13:44
aa16590
to
e6d257c
Compare
…n getConnectedNetwork
tuliomir
approved these changes
Jul 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I would only inform in the PR description itself that SendTx
will be dealt with later, as there are many references to it in this PR and not having it implemented seems to be an oversight.
packages/hathor-rpc-handler/src/rpcMethods/getConnectedNetwork.ts
Outdated
Show resolved
Hide resolved
packages/hathor-rpc-handler/src/rpcMethods/sendNanoContractTx.ts
Outdated
Show resolved
Hide resolved
pedroferreira1
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The idea of this library is to be used by the wallets or by any client wanting to accept the RPC calls defined in the RPC protocol
Some general notices:
camelCase
andsnake_case
, we should standardize the params and update the design document, this will be done in the params validation PR (part3), which should be done before we're able to publish this library.Acceptance Criteria
htr_getAddress
full_path
parameter is not yet implemented, it should be implemented in the part4 PRhtr_getBalance
addressIndexes
is not yet implemented, it should be implemented in the part4 PRhtr_getConnectedNetwork
genesisHash
defined in the RPC design as we don't yet have anAPI to fetch it from the fullnode nor a wallet-lib method to get it. This should be done in a
later unplanned PR as it will involve changes in the fullnode as well as the lib.
htr_getUtxos
limitations, i.e. no pagination and potential memory issues when large
wallets use this method. I think we can publish an initial version with it
as it is, but create an issue to actually solve this as potentially more
users will use this RPC (interacting with dApps) than headless users and
the problem should be more evident on the mobile wallet with constrained
memory.
htr_sendNanoContractTx
htr_signWithAddress
The following methods will be done in the part4 PR:
htr_createToken
htr_pushTxHex
htr_sendTx
The following method will be done in the part5 PR:
htr_getOperationStatus
Checklist
master
, confirm this code is production-ready and can be included in future releases as soon as it gets merged